Skip to content

feat(network): harden NetworkManager layer for 24/7 reliability - #306

Closed
gmmcosta15 wants to merge 17 commits into
devfrom
fix/network-manager-hardening
Closed

feat(network): harden NetworkManager layer for 24/7 reliability#306
gmmcosta15 wants to merge 17 commits into
devfrom
fix/network-manager-hardening

Conversation

@gmmcosta15

@gmmcosta15 gmmcosta15 commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Feature
  • Bug fix
  • Code refactor

Hardens the network layer for 24/7 operation and makes Wi-Fi recovery reliable enough that a user can always get back online to update. Stays fully async on sdbus signal watching.

  • Enforce one active link at a time (Wi-Fi, ethernet or hotspot), on user toggles only; background handlers never drop a link.
  • Persist ethernet-off intent in the wired profile so an NM restart stops resurrecting the cable.
  • Detect hotspot from NM's 802.11 device mode, not an SSID match, so an externally started AP is no longer reported as a client connection.
  • Recover from stale D-Bus device paths by re-detecting interfaces and retrying the signal map.
  • Arm the loading guard before issuing link changes, fixing a toggle that bounced back OFF during ethernet teardown.
  • Support fully disabling the radio, including rfkill, with a recovery path back to a working link.
  • Classify PSK and unknown auth failures instead of hanging with an empty network list on a wrong password.
  • Full-screen numeric keyboard for IP, mask and gateway fields, restyled to match the UI.
  • Cut complexity (no function above C901 threshold 10) and drop per-poll debug logs that spammed the log directory.

Tests

Coverage: models.py 100%, manager.py 99%, keyboardPage.py 90%, networkWindow.py 87%, worker.py 70%.

Future work

  • Radio-cycling phases (Wi-Fi off/on, rfkill, hotspot return to client mode, static IP rewrite) need a run with console or ethernet access. AP-mode hotspot detection is deployed and does not regress client mode, but its assertion lives in a skipped phase.
  • The toggle-bounce fix is UI-driven and has no automated coverage; needs a manual pass on the screen.
  • Coalesce the redundant _build_signal_map fan-out.
  • Stale-path recovery logs the same warning twice at an identical timestamp; cosmetic.
  • NameOwnerChanged would be a cleaner NM-restart trigger.
  • Structural split of worker.py, still large after the complexity work.

@gmmcosta15
fix(network): harden wifi connect wait, interface detection and profi…
b2b3e2b 
…le updates
@gmmcosta15
fix(network): show live AP signal strength on main network page
a984589
@gmmcosta15
fix(network): add reading set values and format keyboard for numeric …
190e0e2 
…type
@gmmcosta15
feat(keyboard): full-screen numpad layout for numeric-only fields
ac73d51
@gmmcosta15
refactor(keyboard): match numpad styling to app UI and fix psk test f…
c70049a 
…ixtures
@gmmcosta15
fix(network): stop ethernet and wifi from disabling each other, re-ar…
afbb3ed 
…m wired autoconnect
@gmmcosta15
feat(network): enforce one active link at a time and move numpad dot …
a0df3f3 
…beside zero
@gmmcosta15
fix(network): persist ethernet off in the wired profile, move numpad …
da76dec 
…dot left of zero
@gmmcosta15
fix(network): make route check intent-aware and match numpad 0 to the…
cd49b35 
… digit grid
@gmmcosta15
fix(network): persist ethernet-off intent when the device is already …
7ac1839 
…inactive
@gmmcosta15
fix(network): retry signal map after re-detecting a stale wifi device…
d340f5d 
… path
@gmmcosta15
chore(network): drop temporary ip_by_iface debug instrumentation
e7edd70
@gmmcosta15
chore(network): drop per-poll debug logs and compress comments to one…
418e153 
…-liners
@gmmcosta15
feat(network): harden NetworkManager layer, cut complexity, expand RF…
54aac20 
…50 test coverage
@gmmcosta15
fix(network): arm loading guard before link changes
2f63ce8
@gmmcosta15
fix(network): detect AP mode as hotspot, arm toggle guard before link…
b40b525 
… changes
@gmmcosta15
docs(network): add module and nested-function docstrings to network a…
f863e99 
…nd keyboard files
@gmmcosta15 gmmcosta15 self-assigned this Aug 26, 2026
@gmmcosta15
gmmcosta15 requested a review from HugoCLSC August 26, 2026 15:32
@gmmcosta15 gmmcosta15 mentioned this pull request Aug 28, 2026
Merged
1 task done
@gmmcosta15

gmmcosta15 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

dived into #308, #309 , #310 , #311 , #312

@gmmcosta15 gmmcosta15 closed this Aug 28, 2026
@gmmcosta15
gmmcosta15 deleted the fix/network-manager-hardening branch September 24, 2026 14:13
gmmcosta15 added a commit that referenced this pull request Sep 28, 2026
@gmmcosta15
fix(network): show live signal strength and classify auth failures (#312
c4ac9d1 
)

# Description
- [x] Bug fix

Stacked on #311, review after it merges. Last PR in the #306 split.

Live Wi-Fi signal strength and auth-failure classification.

- `_active_ap_signal`, `_signal_map_once`, `_read_connectivity`,
`_is_wifi_ap_mode`
- `_classify_settings_error`; `_validate_psk` follows NM's own psk rule
(length in bytes, SAE exempt) and runs before the old profile is backed
up
- `_wait_for_connection` stops early when the Wi-Fi device reports
FAILED (the StateChanged listener counts it, since NM leaves FAILED too
fast for polling to see it)
- Connection waits read the Wi-Fi interface's own IP, so an ethernet or
VPN primary link can't fake success
- `_async_get_network_password` prefills the saved-network password
field; saved page shows the static IP/mask
- `networkWindow.py` operation-result routing (success/failure/timeout
handlers); the hotspot page's activate drops ethernet like the toggle
does
- `test_network_ui.py`, `test_worker_unit.py`,
`test_worker_helpers_unit.py` coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HugoCLSC HugoCLSC Awaiting requested review from HugoCLSC

Assignees

@gmmcosta15 gmmcosta15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gmmcosta15